RDISCROWD-7362 update location pref UI #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbecker42
reviewed
Dec 5, 2024
| @@ -6,7 +6,9 @@ | |||
| <p><strong>Language(s):</strong> {{form.data.languages|join(', ') }}</p> | |||
| {% endif %} | |||
| {% if form.data.locations %} | |||
| <p><strong>Location(s):</strong> {{form.data.locations|join(', ') }}</p> | |||
| <p><strong>Location(s):</strong> | |||
| {% for location in form.data.locations %} {{ '(' ~ location ~ ')' if location|length == 2 else location }}{% if not loop.last %}, {% endif %} {% endfor %} | |||
There was a problem hiding this comment.
Could we adjust this to display the format:
Country Name One (CO), Country Name Two (CP), Country Name Three (CQ)
<p><strong>Location(s):</strong>
{% for i in range(0, form.data.locations|length, 2) %}
{{ form.data.locations[i] }} ({{ form.data.locations[i+1] }}){% if not loop.last %}, {% endif %}
{% endfor %}
</p> There was a problem hiding this comment.
We are not guaranteed to have a country code mapping for each country, so unfortunately we cannot assume [i+1] is a country code.
Adjusted via 3267f47
Updated UI:
kbecker42
approved these changes
Dec 6, 2024
peterkle
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: RDISCROWD-7362
Describe your changes
Add parenthesis around country codes for easy identification